Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #24353 - Propagate cmd flags in interpolation #31768

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Conversation

Keno
Copy link
Member

@Keno Keno commented Apr 18, 2019

Too late for 1.2 for which this was originally marked, but nevertheless,
it's a quick change, so might as well get it in now and have it be available
in 1.3.

Fixes #24353

@Keno Keno requested a review from StefanKarpinski April 18, 2019 23:25
Too late for 1.2 for which this was originally marked, but nevertheless,
it's a quick change, so might as well get it in now and have it be available
in 1.3.

Fixes #24353
@Keno Keno changed the title Implement #24353 - Propegate cmd flags in interpolation Implement #24353 - Propagate cmd flags in interpolation Apr 22, 2019
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Keno Keno merged commit f2fadb3 into master Apr 22, 2019
@martinholters martinholters deleted the kf/24353 branch April 23, 2019 06:43
@KristofferC
Copy link
Member

So in `foo $bar`, foo is considered an "interpolant"?

@StefanKarpinski
Copy link
Member

I would consider the value of bar to be an interpolant, foo is a literal term in the command.

@Keno
Copy link
Member Author

Keno commented Oct 7, 2019

Yeah, the news entry wasn't worded correctly

@KristofferC
Copy link
Member

The error message is worded in the same way.

@Keno
Copy link
Member Author

Keno commented Oct 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interaction of setenv and cmd interpolation
3 participants