Use exact algorithm for cond(A,1), and fix for singular matrices
#33548
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goggle
suggested changes
Oct 13, 2019
|
Thanks @goggle, I changed according to your input. I used the same (convoluted) logic as in |
dkarrasch
reviewed
Oct 15, 2019
|
Looks good to me, let's try to have another pair of eyes on it. BTW, do we need to announce somewhere that we're no longer (silently) returning condition number estimates in some cases? This certainly changes behavior, now the question is if that's simply a "bugfix" or a "breaking change"? |
goggle
reviewed
Oct 15, 2019
dkarrasch
reviewed
Oct 15, 2019
goggle
approved these changes
Oct 15, 2019
StefanKarpinski
added
the
minor change
|
Changing behavior is technically breaking, so I'm putting the "minor change" label on this, but going from an estimate to an exact error is certainly an improvement, so permissible in a minor version. Should have a NEWS entry, however. |
|
Done |
dkarrasch
approved these changes
Oct 17, 2019
|
This seems to be good to go as soon as CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JuliaLang/LinearAlgebra.jl#664
Fix JuliaLang/LinearAlgebra.jl#674