Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-1.6: Set VERSION to 1.6.0-beta1 #39120

Merged
merged 1 commit into from
Jan 8, 2021
Merged

release-1.6: Set VERSION to 1.6.0-beta1 #39120

merged 1 commit into from
Jan 8, 2021

Conversation

KristofferC
Copy link
Member

No description provided.

@KristofferC KristofferC requested a review from ararslan January 6, 2021 11:08
@ararslan
Copy link
Member

ararslan commented Jan 6, 2021

Are we sure we're only going to be doing one beta release? If not, perhaps beta1, which we've used before? Otherwise, LGTM!

@IanButterworth
Copy link
Member

IanButterworth commented Jan 6, 2021 •
edited
Loading

Sorry, the failure is due to a scope error with @time introduced by #38915 that should be fixed by #39133 (which is now passing)

@KristofferC KristofferC added the DO NOT MERGE Do not merge this PR! label Jan 7, 2021
@KristofferC
Copy link
Member Author

Rebased and changed to beta1

@KristofferC KristofferC removed the DO NOT MERGE Do not merge this PR! label Jan 8, 2021
@KristofferC KristofferC changed the title release-1.6: Set VERSION to 1.6.0-beta release-1.6: Set VERSION to 1.6.0-beta1 Jan 8, 2021
@KristofferC KristofferC merged commit b84990e into release-1.6 Jan 8, 2021
@KristofferC KristofferC deleted the tag_1.6_beta branch January 8, 2021 12:42
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
@KristofferC @staticfloat
Set VERSION to 1.6.0-beta1 (#39120)
c60aad0
@BenjaminGalliot BenjaminGalliot mentioned this pull request Mar 31, 2021
Closed
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@KristofferC @staticfloat
Set VERSION to 1.6.0-beta1 (#39120)
6831491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan Awaiting requested review from ararslan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @ararslan @IanButterworth