Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Unicode counterparts of some common operators. #41787

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Addition of Unicode counterparts of some common operators. #41787

wants to merge 9 commits into from

Conversation

BenjaminGalliot
Copy link
Contributor

See #41462.

simeonschaub
simeonschaub reviewed Aug 4, 2021
View reviewed changes
@BenjaminGalliot BenjaminGalliot marked this pull request as ready for review September 17, 2021 21:54
@BenjaminGalliot BenjaminGalliot mentioned this pull request Dec 21, 2021
Open
@ViralBShah
Copy link
Member

@stevengj Do you think we can merge this?

stevengj
stevengj reviewed May 5, 2022
View reviewed changes
stevengj
stevengj reviewed May 5, 2022
View reviewed changes
@BenjaminGalliot
Copy link
Contributor Author

BenjaminGalliot commented May 27, 2022 •
edited
Loading

@stevengj @ViralBShah Anything else I should check or you can see?

stevengj
stevengj reviewed May 27, 2022
View reviewed changes
stevengj
stevengj reviewed May 27, 2022
View reviewed changes
stevengj
stevengj reviewed May 28, 2022
View reviewed changes
base/operators.jl Outdated
The returned function is of type `Base.Fix2{typeof(≮)}`, which can be
used to implement specialized methods.

!!! compat "Julia 1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the wrong version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevengj, Oh, I see, I thought this note was related to Fix2, but how do I know what version of Julia will integrate these modifications? What version should I specify?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specified 1.8, and added some docstrings for inequality operators added.

@BenjaminGalliot
Copy link
Contributor Author

@stevengj @ViralBShah Did I do something wrong with a merging commit, or do we need something else?

@brenhinkeller brenhinkeller added unicode Related to unicode characters and encodings feature Indicates new feature / enhancement requests labels Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

@simeonschaub simeonschaub simeonschaub left review comments

@StefanKarpinski StefanKarpinski Awaiting requested review from StefanKarpinski

Assignees
No one assigned
Labels
feature Indicates new feature / enhancement requests unicode Related to unicode characters and encodings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BenjaminGalliot @ViralBShah @StefanKarpinski @stevengj @simeonschaub @brenhinkeller