Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few more missing AnnotatedStrings tests #55655

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Few more missing AnnotatedStrings tests #55655

merged 1 commit into from
Sep 12, 2024

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Aug 31, 2024

No description provided.

@kshyatt kshyatt added test This change adds or pertains to unit tests strings "Strings!" labels Aug 31, 2024
@kshyatt kshyatt requested a review from tecosaur August 31, 2024 18:17
@kshyatt
Copy link
Contributor Author

kshyatt commented Sep 12, 2024

Could I get a review on this?

@tecosaur
Copy link
Contributor

You certainly can (I had a rather busy period), this looks good to me 👍

Thanks for filling in this gap 🙂

@kshyatt kshyatt merged commit 6af5838 into master Sep 12, 2024
9 checks passed
@kshyatt kshyatt deleted the ksh/annot branch September 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecosaur tecosaur tecosaur approved these changes

Assignees
No one assigned
Labels
strings "Strings!" test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshyatt @tecosaur