-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL #57143
base: master
Are you sure you want to change the base?
Conversation
Also needs to be added in the flisp parser and needs to wait for the JuliaSyntax version bump. |
49ec28c
to
8d4aff6
Compare
8720f42
to
f4d279a
Compare
I'm guessing this PR will also need tests, so I added the label. |
35b915a
to
6669e28
Compare
@nsajko I'm not sure what to test; I can't find any tests for the other arrow operators that already exist. |
6669e28
to
974df2d
Compare
I'd write a simple test like this one: @testset "RIGHTWARDS ARROW WITH LOWER HOOK" begin
(l, r) = 2l + 3r
@test 5 === (1 1)
end Perhaps also something to test its operator precedence? Something like this could be fine, too: Lines 2274 to 2280 in 9a278a2
|
@nsajko Added something based on your second example and the others in that file. |
Correspondingly adds it to the Base id char functions too
282ac2b
to
e9baf11
Compare
Is this ready to merge or are we still waiting on JuliaLang/JuliaSyntaxHighlighting.jl#9 and its followups? |
@Keno Since the branch just happened: is this able to get in for Julia 16 after all, or do we need to undo the JuliaSyntax change that’s already included in 1.0? |
It'll be added to the release branch after merge. There's a couple of other PRs in the same boat |
Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to the flisp parser and REPL, and document it!