Hygiene: Remove randomness from loop in test/linalg.jl. #5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a strong opinion on this change. |
|
Does that mean you're ok with it? |
|
I'm not convinced that moving the sampling of the |
|
One tangible advantage is that we are now dealing with 1 and not 7 integer matrices which might be by chance ill conditioned or singular. |
|
Obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, a different integer matrix was generated for each type combination where eltya or eltyb was integer which makes reasoning and parallelization difficult (#5735).
This also helps a bit with fixing tests after #5741.