-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Iterable string splitting (splititr) #7027
Conversation
This is still WIP, but it supports the basic functionality of
I also noticed that |
immutable SplitItr | ||
str::String | ||
splitter | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this immutable would perform better if it was made parametric
immutable SplitItr{S<:String, T}
str::S
splitter::T
end
@ivarne: Thanks a bundle for the feedback, I have incorporated it into my local repository. I still intend to complete this PR and hope to be able to grab some time this weekend to, my apologies for causing additional messages to go out on the mailing list, do tell me if this was bad style on my part. |
It will be great to see this finished, especially if the performance could be good enough to implement split(...) = collect(splititr(...)) There are lots of posts in the Julia community, and as long as they are "on topic", it is fairly easy for everyone that follows the project to find out if they have anything to contribute on the topic. If you have a question or an opinion, feel free to post. Announcing that you might find time this weekend, is probably not that interesting for everyone to see (especially on a PR that has been silent for 12 days). It is unlikely that someone else will do the job in parallel with you, and because this is performance sensitive code, it will be good to have multiple implementations to test anyway. |
I don't mind the reminder, myself. But then, given the amount of Julia email I get, what's one more? |
6c7c7e3
to
1a4c02f
Compare
Seems like a good addition (sorry for the surprise; I'm looking at really old PR's today). Care to update this to look like the current |
As per discussion in #6933, an iterator variant of
split
(and also possiblyrsplit
) would be useful.