Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary bytestring call for ccall string arguments #7592

Merged
merged 1 commit into from
Jul 14, 2014

Conversation

jakebolewski
Copy link
Member

Due to #5677, bytestring() is now called for for String type arguments in ccall. This removes the remaining explicit bytestring calls in Base for consistency.

@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2014

@jakebolewski
Copy link
Member Author

I hope you were not already working on this :)

@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2014

nah, just searched through for places it was being used

JeffBezanson added a commit that referenced this pull request Jul 14, 2014
remove unnecessary bytestring call for ccall string arguments
@JeffBezanson JeffBezanson merged commit 9f6983f into JuliaLang:master Jul 14, 2014
@jakebolewski jakebolewski deleted the jcb/rm_ccall_bytestring branch July 14, 2014 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants