V4 constructors (take 2) #9346
Merged
V4 constructors (take 2) #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 11, 2014 16:09
|
I don't like the array constructors; it is much clearer just to write |
|
They're commented out for now. I'll just go ahead and remove them entirely. It was in response to @ivarne's suggestion that we have something for vectorization junkies - and I sorta liked the idea. It's gotten enough pushback on IRC and here that it's probably best to nuke it for now. |
Removed the comments since pending decision has apparently been made :)
|
Would still appreciate a review of this PR despite #9350 being closed. Thanks. |
|
+1 |
|
Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - I had to do some rebasing. This PR represents what was discussed in #9321.