-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP/RFC: add cmake build system #9422
Conversation
I've been stuck with this error for the last couple of attempts to make progress on this:
Of course, I'll continue to try to decode the current |
You need to pass -D_GNU_SOURCE to gcc. |
Thanks @few. That got me a tick further. |
Very cool, a good start so far. Before you get too much further, can we prefer spaces instead of tabs please? And as I said in an email I think we'll need to put in some code at some point to check what generator is being used, and fail on in-tree builds for any generators that would overwrite the makefiles. |
We might want to fail outright for in-tree builds with CMake. This has been the policy (born of experience) of every CMake-based application I have worked on and AFAIK is the policy for Kitware products. (one of the issues is that CMake can't track most of the files that end up being created via the platform build system, so getting a clean directory is hard). In-tree restricted to a dedicated subdirectory is probably fine though. |
Maybe not a bad idea. Since this gives us out-of-tree builds right away, may as well forcefully encourage their use. Easier to skip the logic of figuring out what generator we're using, too.
We could probably let git do that part for us, no? |
I think this can be closed in lieu of the further-along #11754. Your input there would be welcomed - we'll want to borrow your snippet to ban in-tree cmake builds once the newer PR gets to be independent of the existing makefiles. |
Addresses #1832.
libsupport
lib/flisp
libjulia
julia
exedist
target