Preallocate workspace #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very welcome PR! It is also a step in the direction of making the algorithm work with different array types. I'll review it a bit later! |
|
Thanks @haampie , seems to pass tests so I'll udraft it. |
That did not happen, but I'll add you as a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this package to solve a very large number of small eigenproblems in parallel. Owing to the large number of solves my runtime was dominated by allocation, so I had to factor out the allocation routines in the partial Schur factorisation.
The PR is a draft as I haven't tested it beyond my own requirements.
If this is of use to a wider audience, I'm happy to clean it up as required. If not, I'm equally happy to close it and maintain a fork.
P.S. Performance is excellent, thanks for your work on this @haampie .