-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility #5
Comments
You could wrap the definitions for the removed functions in a if VERSION < v"0.5-"
...
end block. Ultimately, the only sane thing to do in Combinatorics.jl was to simply maintain separate branches for 0.4 and 0.5, since it became really messy to deal with other breaking changes like how |
Thanks, good to know. In that case, I might register it as-is, so that we can remove it from Base, and then we can make the above change. |
The other option is to add a Compat entry, so that |
How should we make this compatible wth current functionality, so that users don't see a bunch of method overwritten warnings?
Some options:
import Primes: isprime
.Combinatorics.jl has trod this path already (though it was already a package beforehand); @jiahao any thoughts here?
The text was updated successfully, but these errors were encountered: