Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PR to sync up with msun #118

Closed
wants to merge 10 commits into from
Closed

New PR to sync up with msun #118

wants to merge 10 commits into from

Conversation

ViralBShah
Copy link
Member

In order to keep this manageable in the long term, we need to import code from msun and openbsd, and make no modifications to it. Ideally we should have our own headers, and maintain any other changes to sources as patches - so that we can frequently stay updated.

@ViralBShah
Copy link
Member Author

With this PR, much of the stuff compiles without modification of the upstream sources, but this error has me stumped. Any ideas?

clang  -O2 -fno-builtin -std=c99 -Wall -I/Users/viral/repos/openlibm -I/Users/viral/repos/openlibm/include -I/Users/viral/repos/openlibm/ld80 -I/Users/viral/repos/openlibm/amd64 -I/Users/viral/repos/openlibm/src -DASSEMBLER -D__BSD_VISIBLE -Wno-implicit-function-declaration -fPIC -c src/s_csqrt.c -o src/s_csqrt.c.o
src/s_csqrt.c:65:17: error: use of undeclared identifier 'INFINITY'
                return (CMPLX(INFINITY, b));
                              ^
/Users/viral/repos/openlibm/include/openlibm_complex.h:57:41: note: expanded
      from macro 'CMPLX'
#  define CMPLX(x, y) ((double complex){x, y})
                                        ^
1 error generated.
make: *** [src/s_csqrt.c.o] Error 1

@ViralBShah ViralBShah force-pushed the vs/msun branch 3 times, most recently from 517001b to 7bd3db8 Compare February 27, 2016 10:21
tkelman and others added 2 commits February 27, 2016 02:32
This reverts commit 8b3b520.
This was causing dllexport-related errors on win64
@ViralBShah
Copy link
Member Author

The above error is fixed. The tests are passing 100% on linux, but on os x, we have tons on Invalid operation errors. @simonbyrne You seem to have figured out how to fix them on powerpc. Would be great if you could take a look.

@iblislin
Copy link
Contributor

Hi @ViralBShah
About the testing related issue, i will highlight this comment in #10.

I hope that the test/Makefile can add the flag -fno-bulitin.

@ViralBShah
Copy link
Member Author

And added to the tests too - f7a18b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants