Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipnewton_basics.jl #1153

Merged
merged 1 commit into from
Mar 29, 2025
Merged

Update ipnewton_basics.jl #1153

merged 1 commit into from
Mar 29, 2025

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Mar 29, 2025

Fixes #1077

Copy link
Contributor

Benchmark Results

master 1097b87... master / 1097b87...
multivariate/solvers/first_order/AdaMax 0.645 ± 0.0083 ms 0.647 ± 0.0082 ms 0.998
multivariate/solvers/first_order/Adam 0.645 ± 0.0083 ms 0.646 ± 0.0079 ms 0.998
multivariate/solvers/first_order/BFGS 0.226 ± 0.0033 ms 0.223 ± 0.0047 ms 1.01
multivariate/solvers/first_order/ConjugateGradient 0.0479 ± 0.00062 ms 0.0478 ± 0.0007 ms 1
multivariate/solvers/first_order/GradientDescent 1.71 ± 0.015 ms 1.71 ± 0.015 ms 1
multivariate/solvers/first_order/LBFGS 0.219 ± 0.0025 ms 0.219 ± 0.0027 ms 0.997
multivariate/solvers/first_order/MomentumGradientDescent 2.51 ± 0.014 ms 2.51 ± 0.021 ms 0.999
multivariate/solvers/first_order/NGMRES 0.55 ± 0.01 ms 0.553 ± 0.01 ms 0.996
time_to_load 0.52 ± 0.0056 s 0.524 ± 0.0084 s 0.993

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (97f5e3d) to head (1097b87).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files          46       46           
  Lines        3582     3582           
=======================================
  Hits         3078     3078           
  Misses        504      504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkofod pkofod merged commit d5e24c6 into master Mar 29, 2025
22 checks passed
@pkofod pkofod deleted the pkofod-patch-15 branch March 29, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect referencing to ipnewton_basics.ipynb in Nonlinear constrained optimization
1 participant