Normalized multidimensional arrays #776
Conversation
|
Just fix it : Line 69 in 92e3910 x ./= norm(x)
|
thisrod
force-pushed
the
multisphere
branch
2 times, most recently
from
a3140a7 to
de87d0f
Compare
The constraint optimize(..., manifold=Sphere()) used to only normalize vectors. Extending it to arrays of any dimension is straightforward.
Done, I think. |
|
Well actually: JuliaLang/julia#34239 so this would have been fixed by itself. |
|
Is it worth adding a Julia version test, and using |
|
No I think the current version is OK. The tests seem to fail though? |
|
Is there a way to run the tests again? I suspect that I confused Travis by force pushing my branch while it was running. |
|
I think close and reopen? |
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
=======================================
Coverage 76.34% 76.34%
=======================================
Files 42 42
Lines 2021 2021
=======================================
Hits 1543 1543
Misses 478 478
Continue to review full report at Codecov.
|
|
Seems to be working :) |
|
Thanks! |
|
note to self: it's a good idea to put a seed in such a test :) |
The option
Manifold=sphere()is supposed to handle multidimensional arrays. This adds a failing test as a reminder that it doesn't yet.