Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: BREAKING: Completely remove the Slurm functionality from this package (and, in the README, point users to the SlurmClusterManager.jl package instead) #251

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 9, 2025

@DilumAluthge DilumAluthge changed the title BREAKING: Completely remove the Slurm functionality from this package (and, in the README, point users to the SlurmClusterManager.jl package instead) DO NOT MERGE: BREAKING: Completely remove the Slurm functionality from this package (and, in the README, point users to the SlurmClusterManager.jl package instead) Feb 9, 2025
@DilumAluthge DilumAluthge force-pushed the dpa/deprecate-but-do-not-remove-slurm-in-this-package branch 3 times, most recently from 6b1af89 to cbeb2dc Compare February 10, 2025 00:19
@DilumAluthge DilumAluthge force-pushed the dpa/breaking-remove-slurm branch from 577ee74 to 1b03cb5 Compare February 10, 2025 00:20
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.06%. Comparing base (b35ad48) to head (8d5bd9b).

❗ There is a different number of reports uploaded between BASE (b35ad48) and HEAD (8d5bd9b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (b35ad48) HEAD (8d5bd9b)
7 4
Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           dpa/deprecate-but-do-not-remove-slurm-in-this-package     #251       +/-   ##
==========================================================================================
- Coverage                                                  37.85%   24.06%   -13.79%     
==========================================================================================
  Files                                                          7        6        -1     
  Lines                                                        391      295       -96     
==========================================================================================
- Hits                                                         148       71       -77     
+ Misses                                                       243      224       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… (and point users to SlurmClusterManager.jl instead)
@DilumAluthge DilumAluthge force-pushed the dpa/deprecate-but-do-not-remove-slurm-in-this-package branch from cbeb2dc to b35ad48 Compare February 10, 2025 00:23
… (and, in the README, point users to the SlurmClusterManager.jl package instead)
@DilumAluthge DilumAluthge force-pushed the dpa/breaking-remove-slurm branch from 1b03cb5 to 8d5bd9b Compare February 10, 2025 00:24
Base automatically changed from dpa/deprecate-but-do-not-remove-slurm-in-this-package to master February 15, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant