Fix memory leaks in eager API #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jpsamaroo
force-pushed
the
jps/eager-mem-leak-fix
branch
3 times, most recently
from
836987f to
30a50e9
Compare
|
Fixes #225 |
This was referenced Jul 15, 2021
jpsamaroo
force-pushed
the
jps/eager-mem-leak-fix
branch
from
30a50e9 to
08b37db
Compare
Ensure that unreachable thunks are cleaned up by GC Make `add_thunk!` interrupt sleeping scheduler Allow registering eager thunks and single future in `add_thunk!` Make Dagger.spawn synchronous Remove redundant `dependents` and `finished` fields from ComputeState
jpsamaroo
force-pushed
the
jps/eager-mem-leak-fix
branch
from
08b37db to
922dfa2
Compare
|
I've merged this to fix a number of bugs, but it's not yet at 100% because we still get some memory leaks (hence why we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure that we allow eager-allocated
Thunks to become unreferenced by the scheduler when they're no longer needed, so that they and their inputs can be subject to GC.This also fixes a memory leak caused by the dynamic listener not terminating with its associated scheduler, resulting in a leak of the entire
ComputeState.