Skip to content

[DTable] Leftjoin #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 4, 2021
Merged

[DTable] Leftjoin #287

merged 23 commits into from
Dec 4, 2021

Conversation

krynju
Copy link
Member

@krynju krynju commented Oct 10, 2021

  • leftjoin generic for any Tables.jl type
  • innerjoin generic for any Tables.jl type
  • inner matching passes with different kwargs for optimization (r_sorted, l_sorted, r_unique)
  • fallback to specialized methods (e.g. dataframes will use its own joins internally)
  • support for passing lookup tables to quickly match indices using a hash table for example
  • outerjoin research - answer: it's possible but not really nice of a solution, so skip for this PR
  • how to handle dtable x dtable joins? - answer: it works, but not necessairly the optimal way of doing it

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #287 (8b4c042) into master (d06eb91) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #287    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files          40      42     +2     
  Lines        3317    3488   +171     
=======================================
- Misses       3317    3488   +171     
Impacted Files Coverage Δ
src/Dagger.jl 0.00% <ø> (ø)
src/table/dtable.jl 0.00% <ø> (ø)
src/table/join.jl 0.00% <0.00%> (ø)
src/table/join_interface.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06eb91...8b4c042. Read the comment docs.

@krynju krynju force-pushed the kr/dtable-joins branch 2 times, most recently from 9f70abe to 95e1df7 Compare November 22, 2021 19:35
@krynju krynju marked this pull request as ready for review November 22, 2021 19:36
Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@krynju krynju merged commit c5b07cd into JuliaParallel:master Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants