-
-
Notifications
You must be signed in to change notification settings - Fork 73
Switch to the Julia Buildkite queue. #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test failures are probably because we're now being given more than 1 thread? I think it would be best to limit to 1 thread for right now, until Distributed is more thread-safe. |
The tests still specify |
Oh, maybe Sandbox.jl doesn't forward the JULIA_NUM_THREADS variable; with manual usage of the package you needed to set the Let's try setting the thread limit differently. |
Looks like that's working! |
Are those failures expected? I'll let you merge if they are. |
Yeah, they're probably fine. The BK script runs two separate test invocations (idk why), and often the latter run fails. I'll look into disabling the second run. |
Thanks! |
Hmmm. All environment variables should, by default, transfer in. There's really nothing special happening with regards to environment variables. I ran a quick test here: https://github.com/JuliaComputing/BuildkiteTesting/pull/12 and you can see how the environment variable shows up in the build logs. |
Strage; thanks for having a look though. |
Maybe it's as simple as that.