Skip to content

Switch to the Julia Buildkite queue. #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Switch to the Julia Buildkite queue. #290

merged 3 commits into from
Oct 15, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 15, 2021

Maybe it's as simple as that.

@jpsamaroo
Copy link
Member

Test failures are probably because we're now being given more than 1 thread? I think it would be best to limit to 1 thread for right now, until Distributed is more thread-safe.

@maleadt
Copy link
Member Author

maleadt commented Oct 15, 2021

The tests still specify JULIA_NUM_THREADS: 1...

@maleadt
Copy link
Member Author

maleadt commented Oct 15, 2021

Oh, maybe Sandbox.jl doesn't forward the JULIA_NUM_THREADS variable; with manual usage of the package you needed to set the env var. @staticfloat can you confirm?

Let's try setting the thread limit differently.

@jpsamaroo
Copy link
Member

Looks like that's working!

@maleadt
Copy link
Member Author

maleadt commented Oct 15, 2021

Are those failures expected? I'll let you merge if they are.

@jpsamaroo
Copy link
Member

Yeah, they're probably fine. The BK script runs two separate test invocations (idk why), and often the latter run fails. I'll look into disabling the second run.

@jpsamaroo jpsamaroo merged commit 59c7cff into master Oct 15, 2021
@jpsamaroo
Copy link
Member

Thanks!

@jpsamaroo jpsamaroo deleted the tb/julia_buildkite branch October 15, 2021 15:58
@staticfloat
Copy link
Contributor

Oh, maybe Sandbox.jl doesn't forward the JULIA_NUM_THREADS variable

Hmmm. All environment variables should, by default, transfer in. There's really nothing special happening with regards to environment variables.

I ran a quick test here: https://github.com/JuliaComputing/BuildkiteTesting/pull/12 and you can see how the environment variable shows up in the build logs.

@maleadt
Copy link
Member Author

maleadt commented Oct 16, 2021

Strage; thanks for having a look though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants