DTable reduce (on grouped dtable) performance improvements #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(merge before the tables.jl pr - will need to adjust that one once this is merged)
Noticed the grouped reduce is super slow for no real reason (normal reduce is super quick), remembered I just wrapped over normal reduce.
Was a good idea, but it was allocating a lot more than it should and just doing unnecessary work which then had to be transformed later anyway.