chunks: Allow weak Chunk references in Thunk args #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement WeakChunk like WeakThunk Swap Chunk for WeakChunk in eager thunk submission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the scheduler, a task also retains its inputs through entries in
state.cache; this is fine for tasks which references other tasks, because we have aWeakThunkmechanic to allow those input tasks to be freed when unneeded. However, this didn't apply toChunkobjects. This is a simple fix which implements aWeakChunkmechanic in the same way, which allowsChunkinputs to a completed task to be freed.