Skip to content

Updating README.md #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 16, 2023
Merged

Updating README.md #383

merged 9 commits into from
Mar 16, 2023

Conversation

Madhupatel08
Copy link
Contributor

Added the following in the README.md:-
Installation Guide, Contributing Guide, Documentation, Help, and Discussion.

Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I have just a few suggestions and nitpicks.

README.md Outdated

## Documentation
List of recommended Dagger resources:
- https://docs.juliahub.com/Dagger/0a2f8/0.13.3/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- https://docs.juliahub.com/Dagger/0a2f8/0.13.3/
- Docs [![][docs-master-img]][docs-master-url]

Since otherwise we're pointing to a specific, old commit's docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
Additional examples and documentation improvements are also very welcome.

## Documentation
List of recommended Dagger resources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also listing the video links that I sent to you all in Slack? I think they're useful resources to point contributors to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sure. I'll add them.

Madhupatel08 and others added 8 commits March 16, 2023 12:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julian Samaroo <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julian Samaroo <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julian Samaroo <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julian Samaroo <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julian Samaroo <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julian Samaroo <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julian Samaroo <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Changed the heading Documentation to Resources. Since It includes both documentation and videos
@jpsamaroo jpsamaroo merged commit 8d6b234 into JuliaParallel:master Mar 16, 2023
@jpsamaroo
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants