Skip to content

Requires-ify UI deps #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Requires-ify UI deps #417

merged 1 commit into from
Aug 7, 2023

Conversation

jpsamaroo
Copy link
Member

Moves Colors.jl to be a Requires-included dependency, which was taking up a bunch of loading time, as pointed out by @oschulz

@jpsamaroo jpsamaroo added enhancement dependencies Pull requests that update a dependency file labels Aug 7, 2023
@jpsamaroo jpsamaroo force-pushed the jps/remove-extra-deps branch from 77611bc to cbf363b Compare August 7, 2023 19:57
@jpsamaroo jpsamaroo merged commit f64df52 into master Aug 7, 2023
@jpsamaroo jpsamaroo deleted the jps/remove-extra-deps branch August 7, 2023 21:18
@oschulz
Copy link

oschulz commented Aug 8, 2023

Just curious, why not use Pkg extensions on >= v1.9?

@jpsamaroo
Copy link
Member Author

Mostly because I'm busy and didn't have the bandwidth to implement that - feel free to file a PR!

@oschulz
Copy link

oschulz commented Aug 9, 2023

Oh sure - I was worried that maybe there was some problem with distributed operation and Pkg exts or something like that. I'll do a PR.

@oschulz
Copy link

oschulz commented Aug 9, 2023

Here's a first draft: #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants