Skip to content

Sch: Fix various locking and WeakChunk issues #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

jpsamaroo
Copy link
Member

Issues fixed:

  • Locking was done incorrectly during submission in some circumstances
  • Workaround fact that WeakRef cannot be serialized safely via WeakChunk
  • GC retention of pre-submission args was missing
  • Chunk GC retention was done incorrectly w.r.t Chunk hashing behavior

Fixes #437

Construct WeakChunk within scheduler
Add anti-serialization method to WeakChunk
Add Chunk type to Chunk hashing method
Track DRef owner and ID in WeakChunk struct
Preserve old arguments in scheduler submission
Check for matching Chunk in state.waiting_data
@jpsamaroo jpsamaroo merged commit ac56504 into master Oct 16, 2023
@jpsamaroo jpsamaroo deleted the jps/submission-remote-lock branch October 16, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Multiple concurrent writes to Dict detected!" with DTables.reduce
1 participant