Skip to content

DaggerWebDash: Use gethostname and getipaddr #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2023
Merged

DaggerWebDash: Use gethostname and getipaddr #451

merged 3 commits into from
Nov 22, 2023

Conversation

jpsamaroo
Copy link
Member

@jpsamaroo jpsamaroo commented Nov 3, 2023 •
edited
Loading

We were using MemPool.host (which no longer exists), when really we should just call gethostname() or getipaddr().

@mofeing
Copy link

mofeing commented Nov 7, 2023

gethostname() returns a String but a Sockets.IpAddr is required.

Replacing it with Sockets.getipaddr() solves the problem.

@jpsamaroo jpsamaroo force-pushed the jps/webdash-fix-host branch from 795819f to 474686b Compare November 22, 2023 17:44
@jpsamaroo jpsamaroo changed the title DaggerWebDash: Use gethostname DaggerWebDash: Use gethostname and getipaddr Nov 22, 2023
@jpsamaroo
Copy link
Member Author

I had to widen the internal IP/host cache type to accommodate String. I also decided to vendor d3.js, since it's annoying to need an internet connection just to use a purely-local visualizer.

@jpsamaroo jpsamaroo merged commit 60fbf0f into master Nov 22, 2023
@jpsamaroo jpsamaroo deleted the jps/webdash-fix-host branch November 22, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug webdash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpsamaroo @mofeing