Skip to content

processor_runner: Fix race in collect proc_states #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023
Merged

processor_runner: Fix race in collect proc_states #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sch/Sch.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ function start_processor_runner!(istate::ProcessorInternalState, uid::UInt64, re

# Try to steal from local queues randomly
# TODO: Prioritize stealing from busiest processors
states = collect(proc_states(values, uid))
states = proc_states(all_states->collect(values(all_states)), uid)
# TODO: Try to pre-allocate this
P = randperm(length(states))
for state in getindex.(Ref(states), P)
Expand Down