Eagerly free Thunk cached results when unneeded #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the new MemPool destructor functionality to eagerly clean up Thunk cached results once no more EagerThunk handles exist for the Thunk. Will either free the cache immediately, or attempt to do so upon finishing each Thunk.
jpsamaroo
force-pushed
the
jps/chained-dtors
branch
from
1afcf75 to
3781e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of JuliaData/MemPool.jl#76 to allow the scheduler to eagerly free cache task results when unneeded (no further user handles to the task, and no more scheduler-internals downstream dependencies on the task). This simply speeds up the process of freeing memory that the GC will already end up freeing on the next cycle.