Add support for limiting the evaluations of a streaming DAG #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
force-pushed
the
stream-max-evals
branch
2 times, most recently
from
4f357e3 to
4ff2fa1
Compare
|
Also attempted to improve CI by installing the migration-helper branch of MemPool.jl in 4ff2fa1. |
|
I figured out why my filtering was failing, I was doing it in the wrong place 😛 There was some filtering in (P.S. if you approve, I'll rebase this before merging to squash the fixup commits) |
This is useful for testing and benchmarking.
This is currently necessary for the streaming branch, we'll have to change this later but it's good to have CI working for now.
JamesWrigley
force-pushed
the
stream-max-evals
branch
from
f634923 to
b157f89
Compare
|
The CI seems to be a little overloaded so I'm gonna roguishly go ahead and merge this 🏴☠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for testing and benchmarking.
BTW I added the
stream_max_evalsoption toSchedulerOptionsandThunkOptions, but I see that the other streaming options are sort of used adhoc and filtered out before being passed upwards. Is that just for quick prototyping? Or should the streaming options go somewhere else?