-
-
Notifications
You must be signed in to change notification settings - Fork 73
Add render/show_logs to chrome_trace #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry for the delay - this is really cool! I'll review this soon, it looks already really good ❤️ |
jpsamaroo
reviewed
Jul 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work! I think I'll plan to recommend this when users submit bugs/performance issues.
Just a few desired tweaks, and I'd be happy to merge this 😄
jpsamaroo
approved these changes
Jul 8, 2024
Thanks so much @m-fila ! |
13 tasks
davidizzle
pushed a commit
to davidizzle/Dagger.jl
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome tracing is a fairly popular tool for working with traces and process timelines. The traces can be not only displayed but also analyzed and queried with SQL
The Dagger logs can be transformed to a chrome-trace schema json format. The resulting json file can be loaded to https://ui.perfetto.dev/ or legacy
about:tracing
in a chrome-based browserThis can be considered an alternative to the in-house
:plots_gantt
Example output (json file):
For comparison, the same logs printed with
:plots_gantt
Optional dependency on
JSON3
is added, but it's used only to get a json-string from a Dict so it should be possible to easily replace it with any other JSON library in case you have a preferenceFor now only
:compute
events are used (same as in:plots_gantt
) but it should be possible to add support for other types of evetns too