Warn in docs about sync on inner loops #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Wolf Thomsen <[email protected]>
jpsamaroo
approved these changes
Jul 19, 2024
Co-authored-by: Julian Samaroo <[email protected]>
|
Awesome, thanks so much! |
davidizzle
pushed a commit
to davidizzle/Dagger.jl
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Wolf Thomsen <[email protected]> Co-authored-by: Julian Samaroo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main feature is a warning regarding using
@syncon inner loops.There are also some minor grammar fixes to a sentence on the same page, partially thanks to @wolthom for noticing them.