Skip to content

Replace all uses of @async with Threads.@spawn #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

JamesWrigley
Copy link
Collaborator

@JamesWrigley JamesWrigley commented Jul 22, 2024

- Use errormonitor_tracked() for executing DTask's
- Set allow_errors=false by default in the eager scheduler.

I don't know why we had allow_errors=true originally but it seems way too permissive, it caused some internal exceptions to not be logged when I was working on the streaming branch.

@JamesWrigley JamesWrigley self-assigned this Jul 22, 2024
@JamesWrigley JamesWrigley changed the base branch from jps/stream2 to master July 22, 2024 21:21
@JamesWrigley
Copy link
Collaborator Author

In hindsight I should've run the tests locally first 😆 I'll try to fix those errors.

@jpsamaroo jpsamaroo marked this pull request as draft July 30, 2024 19:05
@JamesWrigley JamesWrigley changed the title Improve error monitoring in the scheduler Replace all uses of @async with Threads.@spawn Aug 8, 2024
@JamesWrigley
Copy link
Collaborator Author

Using errormonitor_tracked() would still print out some ugly error messages when I don't think we want it to so I decided to revert that, now the only change is to use Threads.@spawn everywhere instead of @async.

@JamesWrigley JamesWrigley marked this pull request as ready for review August 8, 2024 15:12
@jpsamaroo jpsamaroo merged commit 368df2e into master Aug 9, 2024
8 of 12 checks passed
@jpsamaroo jpsamaroo deleted the sch-errormonitor branch August 9, 2024 13:37
@jpsamaroo
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants