add show_logs for :graphviz
#569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm not going to merge this just yet, as I'd like to integrate it with #560 first. I'll recreate the commits with you as the author. |
|
Implemented in #560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
render_logsgraphviz creates aGraphVizobject that can be later saved to a picture sometimes it's more convenient to be able to save to adottext format (tune the file if needed, for instance remove some details or vertices for presentation) and then render to a picture with an externaldottool.Both
show_logsandrender_logsfor:graphvizuse the same implementation. Theshow_logsand associated functions were moved to visualizations from extension as they don't depend onGraphVizpackage (render_logsdoes)