Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mul! from LinearAlgebra instead of a local definition #217

Merged
merged 3 commits into from
May 19, 2020
Merged

Use mul! from LinearAlgebra instead of a local definition #217

merged 3 commits into from
May 19, 2020

Conversation

haampie
Copy link
Contributor

@haampie haampie commented May 18, 2020

Fixes a missing import of mul!, which causes DistributedArrays.jl to miss fast implementations of mul! when defined outside the package.

@andreasnoack
Copy link
Member

Could you change the .travis.yml to test on julia: 1 such that we test this on the latest release?

@haampie haampie closed this May 18, 2020
@haampie haampie reopened this May 18, 2020
@haampie
Copy link
Contributor Author

haampie commented May 19, 2020

This is good to go

@vchuravy vchuravy merged commit f1459be into JuliaParallel:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haampie @andreasnoack @vchuravy