Distributed fixes #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal function `jl_set_const` is allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 88.12% 88.10% -0.02%
==========================================
Files 11 11
Lines 2096 2118 +22
==========================================
+ Hits 1847 1866 +19
- Misses 249 252 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cherry-picked most of the recent commits from @IanButterworth's push to get Distributed threadsafe. A few are skipped because I didn't feel they were completely safe (e.g.
@asyncto@spawn) or I don't fully understand them yet (e.g. JuliaLang/Distributed.jl@2b0ba72).Most of the commits are semantically identical to their upstream counterparts, with the exception of b41f62a (JuliaLang/Distributed.jl#125) which I put behind a
@static ifto keep support for versions <1.12.