Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate "global const foo = bar" from __init__ #279

Merged
merged 7 commits into from
May 24, 2016
Merged

Conversation

stevengj
Copy link
Member

This eliminates the global const assignments from __init__, since this is deprecated and doesn't play well with precompilation (JuliaLang/julia#12010).

@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage decreased (-0.4%) to 58.729% when pulling 6547543 on noglobalconst into 3ac6ca8 on master.

@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage increased (+0.007%) to 59.094% when pulling 4be9ca3 on noglobalconst into 3ac6ca8 on master.

@cstjean
Copy link
Collaborator

cstjean commented May 24, 2016

I don't know enough about PyCall for a detailed review, but this looks OK.

I wouldn't be surprised if some libraries refer PyCall.pynothing... I know it's not exported, but maybe it should be.

@stevengj
Copy link
Member Author

According to a grep of all registered packages, no one is using pynothing outside of PyCall itself.

@stevengj stevengj merged commit 8146358 into master May 24, 2016
@stevengj stevengj deleted the noglobalconst branch May 24, 2016 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants