Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.10 (on Julia 1.6) #928

Closed
wants to merge 1 commit into from

Conversation

PallHaraldsson
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #928 (d2cf489) into master (8a98fb4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   68.03%   68.02%   -0.01%     
==========================================
  Files          20       20              
  Lines        1980     2033      +53     
==========================================
+ Hits         1347     1383      +36     
- Misses        633      650      +17     
Flag Coverage Δ
unittests 68.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pydates.jl 93.10% <0.00%> (-3.27%) ⬇️
src/pybuffer.jl 61.11% <0.00%> (-0.80%) ⬇️
src/exception.jl 60.74% <0.00%> (-0.80%) ⬇️
src/pyarray.jl 70.00% <0.00%> (-0.55%) ⬇️
src/pyeval.jl 70.47% <0.00%> (-0.12%) ⬇️
src/gui.jl 0.00% <0.00%> (ø)
src/conversions.jl 63.32% <0.00%> (+<0.01%) ⬆️
src/pyclass.jl 96.72% <0.00%> (+0.05%) ⬆️
src/pyfncall.jl 97.36% <0.00%> (+0.14%) ⬆️
src/io.jl 83.33% <0.00%> (+0.23%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a98fb4...d2cf489. Read the comment docs.

@PallHaraldsson
Copy link
Contributor Author

Hopefully that's a correct change assuming the build system had Python 3.10 (which is out), but it seems it doesn't. I just overwrote, not sure we need to also test older versions (or Julia 1.5 or older).

One question, should PyCall work in exceptional cases? All libraries should work, and I see, thrown exceptions, not caught propagate to Julia. At least FYI for upcoming Python 3.11:

PEP 654 -- Exception Groups and except*
https://www.python.org/dev/peps/pep-0654/

@tkf
Copy link
Member

tkf commented Oct 24, 2021

I don't think the exception group needs an explicit support in PyCall?

FYI, we don't need to do this anymore after #932 and #933.

@tkf tkf closed this Oct 24, 2021
@PallHaraldsson PallHaraldsson deleted the patch-9 branch October 24, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants