Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 is latest #986

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Python 3.10 is latest #986

merged 1 commit into from
Apr 19, 2022

Conversation

PallHaraldsson
Copy link
Contributor

@PallHaraldsson PallHaraldsson commented Apr 19, 2022

I noticed Python 3.6 is EOLed, and was thinking you may not want say you support it (I didn't locate it), nor test it(?) to not waste resources (nor 2.7?). Maybe default to latest version, for Conda/Windows downloads, so people can profit from latest features?

Also there are security issues with all minor release of all 3.10, 3.9 down to 3.7 (documented) and likely 3.6 and 2.7 and older.

I'm not sure, but it seems 2.7 is still tested...

[skip ci]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
I noticed Python 3.6 is EOLed, and was thinking you may not want say you support it (I didn't locate it), nor test it(?) to not waste resources (nor 2.7?). Maybe default to latest version, for Conda/Windows downloads, so people can profit from latest featuers?

I'm not sure, but it seems 2.7 is still tested...
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #986 (0a1bf2b) into master (2728e20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   68.36%   68.36%           
=======================================
  Files          20       20           
  Lines        2023     2023           
=======================================
  Hits         1383     1383           
  Misses        640      640           
Flag Coverage Δ
unittests 68.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2728e20...0a1bf2b. Read the comment docs.

PallHaraldsson added a commit to PallHaraldsson/PythonCall.jl that referenced this pull request Apr 19, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
I'm unclear which version you download by default, I suggest latest 3.10.x. Recent versions of all versions down to 3.7, and likely way far back have security issue, see: JuliaPy/PyCall.jl#986

Not stating support is mostly a service to your users, and yourself so they and you indirectly may not get into trouble. You could amend to has been tested down to 3.5, worked at some point, not recommended.

[skip ci]
@stevengj
Copy link
Member

Since these are just examples in the README, it's not a big deal, but might as well update.

@stevengj stevengj merged commit b27bd5a into JuliaPy:master Apr 19, 2022
@PallHaraldsson PallHaraldsson deleted the patch-7 branch April 19, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants