Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct Julia minimum version to ≥ 1.6 #155

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Conversation

stevengj
Copy link
Member

Your Project.toml currently lists julia = "1", but in my testing it seems that it requires Julia 1.6+ (and your CI tests also require 1.6+).

In particular, you depend on MicroMamba.jl, which also requires Julia 1.6+. But if you try to install PythonCall on an earlier Julia version, it just pulls in an earlier version of MicroMamba (before this commit).

On earlier versions of Julia, I get errors like:

julia> using PythonCall
[ Info: Precompiling PythonCall [6099a3de-0909-46bc-b1f4-468b9a2dfc0d]
    CondaPkg Found dependencies: /Users/stevenj/.julia/packages/PythonCall/B5irB/CondaPkg.toml
  MicroMamba Downloading: https://micro.mamba.pm/api/micromamba/osx-64/latest
  MicroMamba Installing: /Users/stevenj/.julia/scratchspaces/0b3b1443-0f03-428d-bdfb-f27f9c1191ea/install/micromamba
ERROR: InitError: /Users/stevenj/.julia/scratchspaces/0b3b1443-0f03-428d-bdfb-f27f9c1191ea/install/micromamba does not seem to be a MicroMamba executable
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] executable(; io::Base.TTY) at /Users/stevenj/.julia/packages/MicroMamba/lsDkG/src/MicroMamba.jl:127
 [3] cmd(; io::Base.TTY) at /Users/stevenj/.julia/packages/MicroMamba/lsDkG/src/MicroMamba.jl:202
 [4] #cmd#13 at /Users/stevenj/.julia/packages/MicroMamba/lsDkG/src/MicroMamba.jl:209 [inlined]
 [5] _resolve_conda_create(::Base.TTY, ::String, ::Array{CondaPkg.PkgSpec,1}, ::Array{String,1}) at /Users/stevenj/.julia/packages/CondaPkg/qEpDY/src/CondaPkg.jl:281
 [6] resolve(; force::Bool, io::Base.TTY) at /Users/stevenj/.julia/packages/CondaPkg/qEpDY/src/CondaPkg.jl:375
 [7] resolve() at /Users/stevenj/.julia/packages/CondaPkg/qEpDY/src/CondaPkg.jl:327
 [8] envdir at /Users/stevenj/.julia/packages/CondaPkg/qEpDY/src/CondaPkg.jl:482 [inlined]
 [9] init_context() at /Users/stevenj/.julia/packages/PythonCall/B5irB/src/cpython/context.jl:54
 [10] __init__() at /Users/stevenj/.julia/packages/PythonCall/B5irB/src/cpython/CPython.jl:20
 [11] _include_from_serialized(::String, ::Array{Any,1}) at ./loading.jl:697
 [12] _require_from_serialized(::String) at ./loading.jl:749
 [13] _require(::Base.PkgId) at ./loading.jl:1040
 [14] require(::Base.PkgId) at ./loading.jl:928
 [15] require(::Module, ::Symbol) at ./loading.jl:923

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #155 (8ee148f) into main (b4528b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   29.01%   29.01%           
=======================================
  Files          70       70           
  Lines        4012     4012           
=======================================
  Hits         1164     1164           
  Misses       2848     2848           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4528b7...8ee148f. Read the comment docs.

@cjdoris
Copy link
Collaborator

cjdoris commented Apr 20, 2022

Great thanks!

@cjdoris cjdoris merged commit b3a1475 into JuliaPy:main Apr 20, 2022
@stevengj stevengj deleted the patch-2 branch April 21, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants