Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass settings from -Xjuliacall_ to julia #192

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

dpinol
Copy link
Contributor

@dpinol dpinol commented Jun 27, 2022

added support for --threads, --procs, --min-optlevel

Fixes #184

added support for --threads, --procs, --min-optlevel
@cjdoris
Copy link
Collaborator

cjdoris commented Jun 30, 2022

Great PR, thank you! Most of the options seem to work great, but some require special handling:

The first one should be fixed in this PR. I'm happy to leave the others for separate PRs (and not document them yet) - it's up to you.

Speaking of bindir, there is the Julia env var JULIA_BINDIR and the command line option --home, hence the naming discrepancy in the first bullet point. It seems like JuliaCall should have similar behaviour (PYTHON_JULIACALL_BINDIR and -X juliacall_home) to be consistent with Julia. Opinions?

@cjdoris
Copy link
Collaborator

cjdoris commented Jun 30, 2022

I've just pushed a change to the main branch which, when merged with this PR, means that opt_procs works.

@thautwarm
Copy link

thautwarm commented Jul 1, 2022

opt_bindir and opt_sysimage are parsed by jl_parse_opts but have no further effect. I think the call to jl_init__threading needs to be replaced by jl_init_with_image__threading.

After merging this, I could make a PR for supporting opt_bindir and opt_sysimage.

@cjdoris cjdoris merged commit 1894606 into JuliaPy:main Jul 1, 2022
@dpinol
Copy link
Contributor Author

dpinol commented Jul 1, 2022

thank you guys!

@cjdoris
Copy link
Collaborator

cjdoris commented Jul 1, 2022

I've merged this PR and made a few tweaks, to get the bindir/home option working. I've also changed the -X options to use --separated words instead of _. And they are documented here: https://cjdoris.github.io/PythonCall.jl/dev/juliacall/#julia-config

A PR to support bindir and sysimage would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure julia options
3 participants