Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documenter -> v1 #372

Merged
merged 5 commits into from
Sep 30, 2023
Merged

Conversation

pedromxavier
Copy link
Contributor

This PR aims to update the Documenter.jl version to v1, thus closes #359.

The DocsNode API changed significantly in v1, so we might need some help from @mortenpi to restore the previous functionality.

@pedromxavier
Copy link
Contributor Author

Documentation is currently building but the juliacall dropdowns are not working properly.

@pedromxavier
Copy link
Contributor Author

Dropdown is now expanding but there's still a annoying link issue that scrolls up upon clicking.

@pedromxavier
Copy link
Contributor Author

Apparently, this hack does the trick.

@pedromxavier
Copy link
Contributor Author

@cjdoris, please label this PR as 'documentation'. I've added an action trigger to generate previews for PR labeled this way.

@cjdoris cjdoris added the documentation Improvements or additions to documentation label Sep 29, 2023
@pedromxavier
Copy link
Contributor Author

The preview was not produced because the PR didn't originate in JuliaPy/PythonCall. Nevertheless, it should work for future PRs. I think this PR is ready for review.

@cjdoris cjdoris merged commit 2ab25aa into JuliaPy:main Sep 30, 2023
@cjdoris
Copy link
Collaborator

cjdoris commented Sep 30, 2023

Just built the docs locally - they look great. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Documenter v1
2 participants