Fix issymmetric
for matrices with empty columns
#606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
issymmetric
check tracks anoffset
that it uses to go from (row, col) to (col, row). However, currently this doesn't account for the fact that if a column is empty, entries incolptr
will be identical. E.g., in #605, we haveThe offset
3
corresponds to rows in the third column, as the second column is empty. This PR checks for empty columns, in which case we may exit the call immediately.Fixes #605