Replace v == zero(v)
with _iszero
#610
Open
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to not call
==
directly, and use_iszero
instead. This is to help integration with IntervalArithmetic.jl since==
for ourInterval
type does not always return a Boolean.Closes #609.
I did not change two checks using
===
since this would break the behaviour for-0.0
. If I understood correctly, it should not be an issue withInterval
, since it will returnfalse
consistently (it may be sub-optimal, but not wrong)cc @dpsanders, @Kolaru
cc also @kalmarek, since you raised JuliaIntervals/IntervalArithmetic.jl#628 you may have more experience mixing SparseArrays and IntervalArithmetic
I do not know how to the backporting procedure works, but it'd be great to have this for 1.10 and 1.11.