-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the missing commits from Julia repo here #7
Conversation
Co-authored-by: Daniel Karrasch <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 88.98% 89.36% +0.37%
==========================================
Files 7 7
Lines 5694 5715 +21
==========================================
+ Hits 5067 5107 +40
+ Misses 627 608 -19
Continue to review full report at Codecov.
|
Can't we enable whatever kind of merging / rebasing we want on the repo? |
@dkarrasch Can you take a look as well? |
LGTM. The only minor question I have is about the compat entries in the sparse xcat docstrings. Is that still appropriate for external stdlibs? I'm not sure, but I guess so, since we don't have independent version management, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enabled rebase-merge.
Ideally, this would be merged with rebase and merge but that is disabled so I guess we just go with a merge commit.