Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing commits from Julia repo here #7

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Jan 14, 2022

Ideally, this would be merged with rebase and merge but that is disabled so I guess we just go with a merge commit.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #7 (0c49b32) into main (61a918f) will increase coverage by 0.37%.
The diff coverage is 86.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   88.98%   89.36%   +0.37%     
==========================================
  Files           7        7              
  Lines        5694     5715      +21     
==========================================
+ Hits         5067     5107      +40     
+ Misses        627      608      -19     
Impacted Files Coverage Δ
src/sparsevector.jl 94.11% <76.00%> (+0.31%) ⬆️
src/sparsematrix.jl 95.39% <96.29%> (+0.33%) ⬆️
src/SparseArrays.jl 100.00% <100.00%> (+88.88%) ⬆️
src/abstractsparse.jl 31.03% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a918f...0c49b32. Read the comment docs.

@ViralBShah
Copy link
Member

Can't we enable whatever kind of merging / rebasing we want on the repo?

@ViralBShah
Copy link
Member

@dkarrasch Can you take a look as well?

@dkarrasch
Copy link
Member

LGTM. The only minor question I have is about the compat entries in the sparse xcat docstrings. Is that still appropriate for external stdlibs? I'm not sure, but I guess so, since we don't have independent version management, right?

Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled rebase-merge.

@KristofferC KristofferC merged commit 205b770 into main Jan 14, 2022
@KristofferC KristofferC deleted the kc/update branch January 14, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants