Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage #249

Merged
merged 2 commits into from
Jun 18, 2014
Merged

Add coverage #249

merged 2 commits into from
Jun 18, 2014

Conversation

IainNZ
Copy link
Contributor

@IainNZ IainNZ commented Jun 18, 2014

Fixes #248

@IainNZ
Copy link
Contributor Author

IainNZ commented Jun 18, 2014

Someone with some measure of ownership over Distributions will need to go on Coveralls.io and enable it there

@IainNZ
Copy link
Contributor Author

IainNZ commented Jun 18, 2014

I'd enable it before merging this, that way this merge will trigger a submission and you can check its worked correctly.

@simonster
Copy link
Member

Enabled.

johnmyleswhite added a commit that referenced this pull request Jun 18, 2014
@johnmyleswhite
Merge pull request #249 from IainNZ/patch-1
a212078 
Add coverage
@johnmyleswhite johnmyleswhite merged commit a212078 into JuliaStats:master Jun 18, 2014
@johnmyleswhite
Copy link
Member

And merged. :)

Thanks, Iain!

@IainNZ IainNZ deleted the patch-1 branch June 18, 2014 19:45
@IainNZ
Copy link
Contributor Author

IainNZ commented Jun 18, 2014

No problem!

@IainNZ
Copy link
Contributor Author

IainNZ commented Jun 18, 2014

Unfortunately looks like tests are failing, so it won't submit any coverage until a build passes

@lindahua
Copy link
Contributor

Some refactoring is going on. I will deal with the failure soon.

@lindahua
Copy link
Contributor

Now the tests passed. However, the coverage information isn't available ...

@lindahua
Copy link
Contributor

It works now. Thanks!

@IainNZ
Copy link
Contributor Author

IainNZ commented Jun 18, 2014

The badge updates much less quickly than the Travis one, but clicking on it should give more up to date results.

IainNZ added a commit to JuliaCI/Coverage.jl that referenced this pull request Jun 18, 2014
@IainNZ
Add Distributions
f60e741 
JuliaStats/Distributions.jl#249
@IainNZ
Copy link
Contributor Author

IainNZ commented Jun 18, 2014

Also: it actually overestimates coverage, due to a "glitch" in --code-coverage, e.g. https://coveralls.io/files/223797062 you can see many functions with no counts but not a 0 count. I thought there was an issue but I can't find it right now JuliaLang/julia#5423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage of test suite
4 participants
@IainNZ @simonster @johnmyleswhite @lindahua