This repository was archived by the owner on May 4, 2019. It is now read-only.
Full 0.5/0.4 compat + fix failing tests #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 82.04%@@ master #113 diff @@
==========================================
Files 13 13
Lines 673 674 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 552 553 +1
Misses 121 121
Partials 0 0
|
| @@ -60,7 +60,7 @@ module TestConstructors | |||
| @test isa(Z, NullableVector{Int}) | |||
| @test Z.isnull == [false, true, false, false, false, false, true] | |||
|
|
|||
| Y = NullableArray([1, "na", 2, 3, 4, 5, "na"], Int, ASCIIString) | |||
| Y = NullableArray([1, "na", 2, 3, 4, 5, "na"], Int, Compat.ASCIIString) | |||
There was a problem hiding this comment.
I'd rather change this into Y = NullableArray([1, nothing, 2, 3, 4, 5, nothing], Int, Void) or Y = NullableArray(Nullable{Int}[1, Nullable(), 2, 3, 4, 5, Nullable()]).
| @@ -1,5 +1,5 @@ | |||
| module TestConstructors | |||
| using Base.Test | |||
| using Base.Test, Compat | |||
There was a problem hiding this comment.
With the change, you don't need Compat AFAICT. Other than that, looks good to merge. Thanks for doing this!
|
Updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.