This repository was archived by the owner on May 4, 2019. It is now read-only.
Update index checkbounds API #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now formally supported and documented due to JuliaLang/julia#11895. Note: this does not compat-ably version the change.
| length(I) == sz || throw(BoundsError()) | ||
| function Base.checkbounds(::Type{Bool}, sz::Int, I::NullableVector{Bool}) | ||
| anynull(I) && throw(NullException()) | ||
| length(I) == sz |
There was a problem hiding this comment.
This changes the semantics here (beyond just the rename)… but I'm pretty sure that this is actually what you want.
There was a problem hiding this comment.
I agree that this is what's wanted.
johnmyleswhite
added a commit
that referenced
this pull request
Aug 26, 2015
Update index checkbounds API
|
Thanks, Matt! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now formally supported and documented due to JuliaLang/julia#11895. Note: this does not compat-ably version the change, but simply points the way to the new API.