Fix #28, fix ShortString constructor #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git cam Fix
ScottPJones
force-pushed
the
spj/constructor
branch
from
02a32c1 to
cf4d927
Compare
oxinabox
approved these changes
Nov 4, 2020
| const CHUNKSZ = sizeof(UInt) | ||
| const CHUNKBITS = sizeof(UInt) == 4 ? 32 : 64 | ||
|
|
||
| @inline function _ss(::Type{T}, str::String, sz) where {T} |
There was a problem hiding this comment.
Why not write:
Suggested change
| @inline function _ss(::Type{T}, str::String, sz) where {T} | |
| @inline function _ss(T::Type, str::String, sz) |
Also would be good with a docstring or a comment explaining what it is.
There was a problem hiding this comment.
I originally just had T, but then worried that Julia might not specialize on that, didn't have the time to double check.
I'll had the docstring in the next PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the access violations that ZJ had seen, where the unsafe_load was trying to access past the end of allocated memory.
Currently, it just does the loading a byte at a time for
SubString{String}, but that will be fixed in a later PR to use the same techniques that I used inStrBase.jl, i.e. to align the pointer and only make aligned 4/8 byte loads that are guaranteed to be safe, and then mask / shift.