Julia 0.7 #30
Julia 0.7 #30
Conversation
REQUIRE
Outdated
| julia 0.7- | ||
| BinaryProvider 0.3.0 | ||
| julia 0.7 | ||
| BinaryProvider 0.4.0 |
There was a problem hiding this comment.
This will have to be 0.4.1, once JuliaPackaging/BinaryProvider.jl#97 is merged.
| @@ -21,7 +21,7 @@ for (s, enc) in (("noël", "ISO-8859-1"), | |||
| end | |||
|
|
|||
| # Test that attempt to close stream in the middle of incomplete sequence throws | |||
| let s = "a string チャネルパートナーの選択", a = Vector{UInt8}(s) | |||
| let s = "a string チャネルパートナーの選択", a = unsafe_wrap(Vector{UInt8}, s) | |||
There was a problem hiding this comment.
I think that is the right fix, but now tests fail...
There was a problem hiding this comment.
I don't think anything needs to be changed, IIRC this will now make a copy but it's OK.
|
I need a working version of this package to get ReadStat.jl to work on 1.0. ReadStat.jl has a dep on this here, so that it will load the same IConv library as this package here. A bit of a hack, but I think the right approach until the BinaryProvider situation gets better. |
|
Same situation with SASLib.jl. |
|
@nalimilan could you restart the one failed build? I think it just timed out. Given that everything else passed, this PR is most likely actually ok. |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 90.54% 90.47% -0.07%
==========================================
Files 2 2
Lines 148 147 -1
==========================================
- Hits 134 133 -1
Misses 14 14
Continue to review full report at Codecov.
|
REQUIRE
Outdated
| julia 0.7- | ||
| BinaryProvider 0.3.0 | ||
| julia 0.7 | ||
| BinaryProvider 0.4.0 |
appveyor.yml
Outdated
| - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x86/julia-latest-win32.exe" | ||
| - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x64/julia-latest-win64.exe" | ||
| - julia_version: 0.7 | ||
| - julia_version: 1 |
There was a problem hiding this comment.
I'd prefer 1.0 (there's a long thread about this somewhere).
appveyor.yml
Outdated
|
|
||
| matrix: | ||
| allow_failures: | ||
| - julia_version: latest |
|
@nalimilan Alright, I think ready to merge and then tag a release, right? |
|
Yes, thanks! |
This is not enough to get things passing on 1.0, but it is a start. I'll have some more comments inline.