-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix system image incompatibility with LibCURL.cacert
#84
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=========================================
+ Coverage 6.81% 7.51% +0.70%
=========================================
Files 2 2
Lines 132 133 +1
=========================================
+ Hits 9 10 +1
Misses 123 123
Continue to review full report at Codecov.
|
I was looking into writing some tests for this but I've been unable to reproduce the failure that existed without this change using something like: using PackageCompiler
create_sysimage(:LibCURL; sysimage_path="LibCURL.so")
run(`$(Base.julia_cmd()) -JLibCURL.so -E '@assert !isempty(LibCURL.cacert)'`) I may look into this further but I don't think it's essential to add a test here if I can confirm this fixes the issue. |
Co-authored-by: Nicole Epp <[email protected]>
Globals should be set as |
I don't disagree. However, I want this change to be non-breaking and using a |
I've made an issue against BinaryBuilder.jl: JuliaPackaging/BinaryBuilder.jl#829 |
I have confirmed that this fixes the incompatibility with the system image. |
When attempting to reference
LibCURL.cacert
from within a system image the returned path would be""
as this is what MozillaCACerts_jll stores before initialization.